Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): soften readiness gate failure message (#13972) (#14076) #14079

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix(ui): soften readiness gate failure message (#13972) (#14076) #14079

merged 1 commit into from
Jun 15, 2023
+26 −25

Conversation

crenshaw-dev
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@crenshaw-dev
fix(ui): soften readiness gate failure message (argoproj#13972) (argo…
1fbac6e 
…proj#14076)

* fix(ui): soften readiness gate failure message (argoproj#13972)

Signed-off-by: Michael Crenshaw <[email protected]>

* null check everything

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
leoluz
leoluz approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 0df4093 into argoproj:release-2.7 Jun 15, 2023
@crenshaw-dev crenshaw-dev deleted the release-2.7-readiness-gate branch June 15, 2023 17:21
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@crenshaw-dev @schakrad
fix(ui): soften readiness gate failure message (argoproj#13972) (argo…
890ab61 
…proj#14076) (argoproj#14079)

* fix(ui): soften readiness gate failure message (argoproj#13972)

* null check everything

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @leoluz